Horizon Platform Community Node Bounty
Thread Posts Reply To This Post
Viewing 10 posts - 1 through 10 (of 34 total)
  • whiteblue

    9th April 2014 at 5:39 pm

    Hi,

    I didn´t know in which category this fits best.

    The node bounty payout is a great idea and seems to work quite stable, but maybe I found a bug in it. It get´s shifted by 3 hours every day. This is my transaction log:

    9.4.2014 09:07:05
    8.4.2014 06:01:16
    7.4.2014 03:00:18
    6.4.2014 00:02:06
    4.4.2014 21:00:36

    I think the timer is 27 hours instead of 24.

    Cheers

    cbkr
    Participant

    Horizon: 0.00 HZ
    9th April 2014 at 7:51 pm

    Oh, thanks for reporting. I think I know what is causing it. Let me have a quick look.

    Fixed as of Wed Apr 9, 20:16 UTC.
    The payout-uptime is now calculated and saved correctly.

    Thanks.

    Want some bug hunting bounty? Just add your NHZ address to your profile here: Profile -> Forum Profile

    nhzfan
    Participant

    Horizon: 14.50 HZ
    10th April 2014 at 6:54 am

    Problem with node bounties

    It seams there is a general problem with online-time measurement of nodes and node bounty payment.
    ‘[list type=decimal]’.str_replace(‘
    ‘, ”, ‘
    [*]The payout is made only once per hour. That would not be a problem, but there is also a time measurement shift.
    Example:
    – estimated payout time: 2014-04-09 19:40:00
    – display of node check at 19:59.59:
    ? ? Uptime until next payout: -20m
    – display of node check at 20:01.00:
    ? ? Last payout: 2014-04-09 20:00:09
    ? ? Uptime until next payout: 1439m
    At each payout there is a “time loss” of up to one hour

    [*]
    There is a permanent shift in the online time measurement.
    Example:
    – immediately after payout: Uptime until next payout: 1440m
    – 7 hours (420m) later: Uptime until next payout: 1064m (44m shift)
    – 14 hours (840m) later: Uptime until next payout: 689m (89m shift)

    ‘).’‘
    The result of the mentioned above ist a permanent shift of payout of 3 hours. This means, that payout is always all 27 hours, not every 24 hours as expected.
    I’ve checked this for several nodes in the last 6 days. Each payout was 3 hours late. The nodes were 24/7 online.

    th4o
    Participant

    Horizon: 0.00 HZ
    10th April 2014 at 7:00 am

    Thanks for fixing :)

    Added my account to profile.

    th4o
    Participant

    Horizon: 0.00 HZ
    10th April 2014 at 8:07 am

    Re: Problem with node bounties

    Hi. I reported this yesterday.

    It should be fixed now.

    See the following thread:
    http://forum.nhzcrypto.org/index.php?topic=15.msg21#new

    nhzfan
    Participant

    Horizon: 14.50 HZ
    10th April 2014 at 8:35 am

    Re: Problem with node bounties

    ‘th4o link’ wrote:
    Hi. I reported this yesterday.

    It should be fixed now.

    See the following thread:
    http://forum.nhzcrypto.org/index.php?topic=15.msg21#new

    fine

    cbkr
    Participant

    Horizon: 0.00 HZ
    10th April 2014 at 11:15 am

    Re: Problem with node bounties

    ‘nhzfan link’ wrote:
    It seams there is a general problem with online-time measurement of nodes and node bounty payment.
    ‘[list type=decimal]’.str_replace(‘
    ‘, ”, ‘
    [*]The payout is made only once per hour. That would not be a problem, but there is also a time measurement shift.
    Example:
    – estimated payout time: 2014-04-09 19:40:00
    – display of node check at 19:59.59:
    ? ? Uptime until next payout: -20m
    – display of node check at 20:01.00:
    ? ? Last payout: 2014-04-09 20:00:09
    ? ? Uptime until next payout: 1439m
    At each payout there is a \”time loss\” of up to one hour

    [*]
    There is a permanent shift in the online time measurement.
    Example:
    – immediately after payout: Uptime until next payout: 1440m
    – 7 hours (420m) later: Uptime until next payout: 1064m (44m shift)
    – 14 hours (840m) later: Uptime until next payout: 689m (89m shift)

    ‘).’‘
    The result of the mentioned above ist a permanent shift of payout of 3 hours. This means, that payout is always all 27 hours, not every 24 hours as expected.
    I’ve checked this for several nodes in the last 6 days. Each payout was 3 hours late. The nodes were 24/7 online.

    This is exactly what I fixed. :)

    Edit: Here, have a small diff of the bugfix:

    '.str_replace('
    ', '', '<? host.last_payout_uptime = host.full_uptime
    >? host.last_payout_uptime = host.full_uptime-(host.full_uptime%Options.payout_time)').'


    (Please respect that we can’t make the script public (yet), because it’s part of the things that make us different and I can think of at least one coin that would want to copy it. We just don’t want them to have all the fun without the work.)

    Edit: I sent both of you a bounty for finding the bug.
    th4o for finding the bug and reporting it first (10k) and to nhzfan for finding it and posting the detailed description (5k) :)

    nhzfan
    Participant

    Horizon: 14.50 HZ
    11th April 2014 at 8:56 am

    Re: Problem with node bounties

    ‘cbkr link’ wrote:

    It seams there is a general problem with online-time measurement of nodes and node bounty payment.
    ‘[list type=decimal]’.str_replace(‘
    ‘, ”, ‘
    [*]The payout is made only once per hour. That would not be a problem, but there is also a time measurement shift.
    Example:
    – estimated payout time: 2014-04-09 19:40:00
    – display of node check at 19:59.59:
    ? ? Uptime until next payout: -20m
    – display of node check at 20:01.00:
    ? ? Last payout: 2014-04-09 20:00:09
    ? ? Uptime until next payout: 1439m
    At each payout there is a \”time loss\” of up to one hour

    [*]
    There is a permanent shift in the online time measurement.
    Example:
    – immediately after payout: Uptime until next payout: 1440m
    – 7 hours (420m) later: Uptime until next payout: 1064m (44m shift)
    – 14 hours (840m) later: Uptime until next payout: 689m (89m shift)

    ‘).’‘
    The result of the mentioned above ist a permanent shift of payout of 3 hours. This means, that payout is always all 27 hours, not every 24 hours as expected.
    I’ve checked this for several nodes in the last 6 days. Each payout was 3 hours late. The nodes were 24/7 online.

    This is exactly what I fixed. :)

    Edit: Here, have a small diff of the bugfix:

    '.str_replace('
    ', '', '<? host.last_payout_uptime = host.full_uptime
    >? host.last_payout_uptime = host.full_uptime-(host.full_uptime%Options.payout_time)').'


    (Please respect that we can’t make the script public (yet), because it’s part of the things that make us different and I can think of at least one coin that would want to copy it. We just don’t want them to have all the fun without the work.)

    Edit: I sent both of you a bounty for finding the bug.
    th4o for finding the bug and reporting it first (10k) and to nhzfan for finding it and posting the detailed description (5k) :)

    Point 1. of my post now works. There is no additional time offset because of hourly payout now.
    Point 2. is currently still true. The permanent shift in online-time measurement now creates payout cycles of 26 hours :-(

    @cbkr: Thank you for the bounty
    ?

    th4o
    Participant

    Horizon: 0.00 HZ
    11th April 2014 at 12:03 pm

    I can confirm that the payout times are a bit weird now. Before your changes it was about all 27 hours (+-some minutes).

    Node 1:
    10.4.2014 01:01:37
    11.4.2014 04:00:37

    Node 2:
    10.4.2014 12:14:55
    11.4.2014 13:02:17

    Node 1 payouts happened again with a 27 hours interval, but for node 2 is was 25 hours?

    cbkr
    Participant

    Horizon: 0.00 HZ
    11th April 2014 at 1:39 pm

    I looked though the code again and still think the patch was correct and introduced no new bug.
    It couldn’t be in effect for nodes that were paid out before I applied it so it just took some time to adjust.
    Please wait for another round of payouts and tell me if it’s still off.

Viewing 10 posts - 1 through 10 (of 34 total)